bo3b,
[s]I have this error now:[/s]
**remove**
[s]Is this line:[/s]
** remove **
Edit: I just miss some line....sorry
@bo3b
I'm still don't get how to manually fix, when a variables changes, can you please help me with this one.
The previous shader works perfect btw...
I just fix the previous shadows shader....the shader attached is from reflection (you can see in the soldier)
[img]https://forums.geforce.com/cmd/default/download-comment-attachment/66945/[/img]
@bo3b
I'm still don't get how to manually fix, when a variables changes, can you please help me with this one.
The previous shader works perfect btw...
I just fix the previous shadows shader....the shader attached is from reflection (you can see in the soldier)
@DHR:
OK, I fixed this second shader, and the checked in version is at:
https://github.com/bo3b/3Dmigoto/blob/f92ed6a455ff10702009ef15c9e2df4fa7ee346c/BO3/d3504b41b3541520-vs_replace.txt
I included some detail in the comments that might help clarify the hand fix for the instruction offsets.
This compiles properly, and generates the same output asm.
I've been studying this ld_structured_indexable, and I think I might be able to fix these now. I want to fix these in the Decompiler because most games we run into now are having this problem. If I can get it working I'll let you know.
Congrats on that Shadow fix for the first one! Very promising.
I included some detail in the comments that might help clarify the hand fix for the instruction offsets.
This compiles properly, and generates the same output asm.
I've been studying this ld_structured_indexable, and I think I might be able to fix these now. I want to fix these in the Decompiler because most games we run into now are having this problem. If I can get it working I'll let you know.
Congrats on that Shadow fix for the first one! Very promising.
Acer H5360 (1280x720@120Hz) - ASUS VG248QE with GSync mod - 3D Vision 1&2 - Driver 372.54
GTX 970 - i5-4670K@4.2GHz - 12GB RAM - Win7x64+evilKB2670838 - 4 Disk X25 RAID
SAGER NP9870-S - GTX 980 - i7-6700K - Win10 Pro 1607 Latest 3Dmigoto Release Bo3b's School for ShaderHackers
Thanks bo3b....the manual fix i was trouble was this line:
[code]r0.x = modelInstanceBuffer[0].worldMatrix.x;[/code]
i was putting this code:
[code]r0.x = modelInstanceBuffer[boneArrayIndex.x].worldMatrix.x;[/code]
I have a trouble with one shader, this is the main shadows shader:
1) The shader is not hunted by the wrapper if i use VS hunting keys. I need the VS.
2) if i search for the PS, i found the PS related....so searching in the the shaderusage.txt i found the VS (d43a46f6c2a4cff9)
3) export_hlsl=1 produce a crash. Only dump 358 shaders (of course no d43a46f6c2a4cff9 was dumped) ....BUT one time i try the wrapper dump 359 shaders, and the 359 was the d43a46f6c2a4cff9 shader....lucky me!!!
4) I manually fix the shader, and press F10....ALL OK but with the shader broken (no fix)
5) I insert the fixing code in the shader, this actually fix the main shadows, BUT some objects disappear (example: the arms and some parts in the face in the soldier in the menu)...see screenshots...in the top left of the head you can see that shadow is fixed.
[img]https://forums.geforce.com/cmd/default/download-comment-attachment/66976/[/img]
My conclusions is that shader have more decompiler issues (I can be wrong with this of course) than only the "ld_structured_indexable" stuff. The fixing code is applied in the "viewProjectionMatrix" part in the bottom of the shader btw.
I fix others lights shaders the same way, all are working fine and i can hunt normally....but this shader is different. Hope you can help. I attach the shader and the ASM version.
And there are others lights shader that can't found either using VS or PS or CS hunting....really strange.
I have a trouble with one shader, this is the main shadows shader:
1) The shader is not hunted by the wrapper if i use VS hunting keys. I need the VS.
2) if i search for the PS, i found the PS related....so searching in the the shaderusage.txt i found the VS (d43a46f6c2a4cff9)
3) export_hlsl=1 produce a crash. Only dump 358 shaders (of course no d43a46f6c2a4cff9 was dumped) ....BUT one time i try the wrapper dump 359 shaders, and the 359 was the d43a46f6c2a4cff9 shader....lucky me!!!
4) I manually fix the shader, and press F10....ALL OK but with the shader broken (no fix)
5) I insert the fixing code in the shader, this actually fix the main shadows, BUT some objects disappear (example: the arms and some parts in the face in the soldier in the menu)...see screenshots...in the top left of the head you can see that shadow is fixed.
My conclusions is that shader have more decompiler issues (I can be wrong with this of course) than only the "ld_structured_indexable" stuff. The fixing code is applied in the "viewProjectionMatrix" part in the bottom of the shader btw.
I fix others lights shaders the same way, all are working fine and i can hunt normally....but this shader is different. Hope you can help. I attach the shader and the ASM version.
And there are others lights shader that can't found either using VS or PS or CS hunting....really strange.
hey DHR,
I saw this tips for stutter issues in this game:
"Stutter fix
For those with memory and stutter issues just open the file config.ini from folder Player in game directory. change as below
MaxFrameLatency = "3"
VideoMemory = "0.75"
BackbufferCount = "3"
No more stutter and memory issues. This may solve the issues till patch.
Hope this helps."
Trechyard said to limit the game at 58fps too
@DHR: When you get a crash on dumping, run it again, and again, until you get all the way into the game. There will be a few missing shaders, but you'll get a better set after multiple tries. It gets a little further each time, that's why you saw that next shader show up.
There definitely looks to be a Decompiler problem with the shader you posted above. It's fine up to the last 20 lines or so, then it runs off the rails. I'm looking into that now.
Edit: Actually not sure, but it looks like there is one small tweak in the original that would be worth trying. It's a swapped variable, instead of .xyzw it's .xywz. Very subtle and easy to miss.
It's the last three of the ld_indexed commands, I've unrolled them here to make it more clear about the swizzle. Try this sequence for those, and see if it doesn't fix the missing arms.
The rest of the code could be correct with the compiler being aggressive and rearranging registers.
[code] // Known bad code for instruction (needs manual fix):
// ld_structured_indexable(structured_buffer, stride=64)(mixed,mixed,mixed,mixed) r3.xyzw, r0.w, l(0), t5.xyzw
r3.x = boneMatrixBuffer[r0.w].mat[0].x;
r3.y = boneMatrixBuffer[r0.w].mat[0].y;
r3.z = boneMatrixBuffer[r0.w].mat[0].z;
r3.w = boneMatrixBuffer[r0.w].mat[0].w;
// Known bad code for instruction (needs manual fix):
// ld_structured_indexable(structured_buffer, stride=64)(mixed,mixed,mixed,mixed) r5.xyzw, r0.w, l(16), t5.xyzw
r5.x = boneMatrixBuffer[r0.w].mat[1].x;
r5.y = boneMatrixBuffer[r0.w].mat[1].y;
r5.z = boneMatrixBuffer[r0.w].mat[1].z;
r5.w = boneMatrixBuffer[r0.w].mat[1].w;
// Known bad code for instruction (needs manual fix):
// ld_structured_indexable(structured_buffer, stride=64)(mixed,mixed,mixed,mixed) r6.xyzw, r0.w, l(32), t5.xywz
r6.x = boneMatrixBuffer[r0.w].mat[2].x;
r6.y = boneMatrixBuffer[r0.w].mat[2].y;
r6.z = boneMatrixBuffer[r0.w].mat[2].w; // <-- w, not z here.
r6.w = boneMatrixBuffer[r0.w].mat[2].z; // z here. Makes no sense, but that's the original.[/code]
@DHR: When you get a crash on dumping, run it again, and again, until you get all the way into the game. There will be a few missing shaders, but you'll get a better set after multiple tries. It gets a little further each time, that's why you saw that next shader show up.
There definitely looks to be a Decompiler problem with the shader you posted above. It's fine up to the last 20 lines or so, then it runs off the rails. I'm looking into that now.
Edit: Actually not sure, but it looks like there is one small tweak in the original that would be worth trying. It's a swapped variable, instead of .xyzw it's .xywz. Very subtle and easy to miss.
It's the last three of the ld_indexed commands, I've unrolled them here to make it more clear about the swizzle. Try this sequence for those, and see if it doesn't fix the missing arms.
The rest of the code could be correct with the compiler being aggressive and rearranging registers.
// Known bad code for instruction (needs manual fix):
// ld_structured_indexable(structured_buffer, stride=64)(mixed,mixed,mixed,mixed) r3.xyzw, r0.w, l(0), t5.xyzw
r3.x = boneMatrixBuffer[r0.w].mat[0].x;
r3.y = boneMatrixBuffer[r0.w].mat[0].y;
r3.z = boneMatrixBuffer[r0.w].mat[0].z;
r3.w = boneMatrixBuffer[r0.w].mat[0].w;
// Known bad code for instruction (needs manual fix):
// ld_structured_indexable(structured_buffer, stride=64)(mixed,mixed,mixed,mixed) r5.xyzw, r0.w, l(16), t5.xyzw
r5.x = boneMatrixBuffer[r0.w].mat[1].x;
r5.y = boneMatrixBuffer[r0.w].mat[1].y;
r5.z = boneMatrixBuffer[r0.w].mat[1].z;
r5.w = boneMatrixBuffer[r0.w].mat[1].w;
// Known bad code for instruction (needs manual fix):
// ld_structured_indexable(structured_buffer, stride=64)(mixed,mixed,mixed,mixed) r6.xyzw, r0.w, l(32), t5.xywz
r6.x = boneMatrixBuffer[r0.w].mat[2].x;
r6.y = boneMatrixBuffer[r0.w].mat[2].y;
r6.z = boneMatrixBuffer[r0.w].mat[2].w; // <-- w, not z here.
r6.w = boneMatrixBuffer[r0.w].mat[2].z; // z here. Makes no sense, but that's the original.
Acer H5360 (1280x720@120Hz) - ASUS VG248QE with GSync mod - 3D Vision 1&2 - Driver 372.54
GTX 970 - i5-4670K@4.2GHz - 12GB RAM - Win7x64+evilKB2670838 - 4 Disk X25 RAID
SAGER NP9870-S - GTX 980 - i7-6700K - Win10 Pro 1607 Latest 3Dmigoto Release Bo3b's School for ShaderHackers
Thanks bo3b for looking!! i will try later
i try that "technique", but always the game dump 358 shaders...i try like 10 times / 10 crashes....and same 358 shaders dumped.
bo3b....same thing changing to .xywz, the arms disappear.
I also try whith that shader only in the shaderfixes folder, if other shader may corrupt that one but the same.
I don't know what else to try....
bo3b....same thing changing to .xywz, the arms disappear.
I also try whith that shader only in the shaderfixes folder, if other shader may corrupt that one but the same.
[quote="DHR"]bo3b....same thing changing to .xywz, the arms disappear.
I also try whith that shader only in the shaderfixes folder, if other shader may corrupt that one but the same.
I don't know what else to try....[/quote]
OK, thanks for trying that out. I'll see if I can get it to generate closer code by tweaking the source. Take me a day or two.
DHR said:bo3b....same thing changing to .xywz, the arms disappear.
I also try whith that shader only in the shaderfixes folder, if other shader may corrupt that one but the same.
I don't know what else to try....
OK, thanks for trying that out. I'll see if I can get it to generate closer code by tweaking the source. Take me a day or two.
Acer H5360 (1280x720@120Hz) - ASUS VG248QE with GSync mod - 3D Vision 1&2 - Driver 372.54
GTX 970 - i5-4670K@4.2GHz - 12GB RAM - Win7x64+evilKB2670838 - 4 Disk X25 RAID
SAGER NP9870-S - GTX 980 - i7-6700K - Win10 Pro 1607 Latest 3Dmigoto Release Bo3b's School for ShaderHackers
I don't know if anyone has said this recently, but you guys are bloody awesome!
It's so amazing to see such highly skilled elites and newcomers, all come together under a common interest, to fix issues which otherwise would be impossible, for the good of everyone :)
I don't know if anyone has said this recently, but you guys are bloody awesome!
It's so amazing to see such highly skilled elites and newcomers, all come together under a common interest, to fix issues which otherwise would be impossible, for the good of everyone :)
Windows 10 64-bit, Intel 7700K @ 5.1GHz, 16GB 3600MHz CL15 DDR4 RAM, 2x GTX 1080 SLI, Asus Maximus IX Hero, Sound Blaster ZxR, PCIe Quad SSD, Oculus Rift CV1, DLP Link PGD-150 glasses, ViewSonic PJD6531w 3D DLP Projector @ 1280x800 120Hz native / 2560x1600 120Hz DSR 3D Gaming.
@bo3b, i fix the shader in ASM...and have the same results. Shadows fixed, but the arms disappear.
Really don't know what happens in this game.....i will try to tweak the fixing code.
The shader is working fine, don't waste the time in there....unless the ASM code is wrong, but i doubt it
@bo3b, i fix the shader in ASM...and have the same results. Shadows fixed, but the arms disappear.
Really don't know what happens in this game.....i will try to tweak the fixing code.
The shader is working fine, don't waste the time in there....unless the ASM code is wrong, but i doubt it
I test a little more and due i have to fix the shadows in the VS (because the PS is useless), that VS is related to many PS, one of them is the shadow and other are some objects.....so indeed fixing the VS affect all PS related included others things, like objects (ex: arm soldier and other stuff). I noticed by changing the fix with a fix value, and noticed that the arm split a little, if increase that value arms start to go out of the screen until disappear and shadows start to align.
I don't know if is possible that the fix only apply in the VS and only in that shadow PS in the pipeline?
The shadow PS is useless, but maybe fixing the v0 (position) in the PS....bringing the "ProjectionMatrix" from the VS....i will test later.
I test a little more and due i have to fix the shadows in the VS (because the PS is useless), that VS is related to many PS, one of them is the shadow and other are some objects.....so indeed fixing the VS affect all PS related included others things, like objects (ex: arm soldier and other stuff). I noticed by changing the fix with a fix value, and noticed that the arm split a little, if increase that value arms start to go out of the screen until disappear and shadows start to align.
I don't know if is possible that the fix only apply in the VS and only in that shadow PS in the pipeline?
The shadow PS is useless, but maybe fixing the v0 (position) in the PS....bringing the "ProjectionMatrix" from the VS....i will test later.
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
I have this error now:**remove**
Is this line:** remove **
Edit: I just miss some line....sorry
@bo3b
I'm still don't get how to manually fix, when a variables changes, can you please help me with this one.
The previous shader works perfect btw...
I just fix the previous shadows shader....the shader attached is from reflection (you can see in the soldier)
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
OK, I fixed this second shader, and the checked in version is at:
https://github.com/bo3b/3Dmigoto/blob/f92ed6a455ff10702009ef15c9e2df4fa7ee346c/BO3/d3504b41b3541520-vs_replace.txt
I included some detail in the comments that might help clarify the hand fix for the instruction offsets.
This compiles properly, and generates the same output asm.
I've been studying this ld_structured_indexable, and I think I might be able to fix these now. I want to fix these in the Decompiler because most games we run into now are having this problem. If I can get it working I'll let you know.
Congrats on that Shadow fix for the first one! Very promising.
Acer H5360 (1280x720@120Hz) - ASUS VG248QE with GSync mod - 3D Vision 1&2 - Driver 372.54
GTX 970 - i5-4670K@4.2GHz - 12GB RAM - Win7x64+evilKB2670838 - 4 Disk X25 RAID
SAGER NP9870-S - GTX 980 - i7-6700K - Win10 Pro 1607
Latest 3Dmigoto Release
Bo3b's School for ShaderHackers
i was putting this code:
I have a trouble with one shader, this is the main shadows shader:
1) The shader is not hunted by the wrapper if i use VS hunting keys. I need the VS.
2) if i search for the PS, i found the PS related....so searching in the the shaderusage.txt i found the VS (d43a46f6c2a4cff9)
3) export_hlsl=1 produce a crash. Only dump 358 shaders (of course no d43a46f6c2a4cff9 was dumped) ....BUT one time i try the wrapper dump 359 shaders, and the 359 was the d43a46f6c2a4cff9 shader....lucky me!!!
4) I manually fix the shader, and press F10....ALL OK but with the shader broken (no fix)
5) I insert the fixing code in the shader, this actually fix the main shadows, BUT some objects disappear (example: the arms and some parts in the face in the soldier in the menu)...see screenshots...in the top left of the head you can see that shadow is fixed.
My conclusions is that shader have more decompiler issues (I can be wrong with this of course) than only the "ld_structured_indexable" stuff. The fixing code is applied in the "viewProjectionMatrix" part in the bottom of the shader btw.
I fix others lights shaders the same way, all are working fine and i can hunt normally....but this shader is different. Hope you can help. I attach the shader and the ASM version.
And there are others lights shader that can't found either using VS or PS or CS hunting....really strange.
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
Intel i7 8086K
Gigabyte GTX 1080Ti Aorus Extreme
DDR4 2x8gb 3200mhz Cl14
TV LG OLED65E6V
Windows 10 64bits
I saw this tips for stutter issues in this game:
"Stutter fix
For those with memory and stutter issues just open the file config.ini from folder Player in game directory. change as below
MaxFrameLatency = "3"
VideoMemory = "0.75"
BackbufferCount = "3"
No more stutter and memory issues. This may solve the issues till patch.
Hope this helps."
Trechyard said to limit the game at 58fps too
http://photos.3dvisionlive.com/chtiblue/album/530b52d4cb85770d6e000049/3Dvision with 49" Philips 49PUS7100 interlieved 3D (3840x2160) overide mode, GTX 1080 GFA2 EXOC, core i5 @4.3GHz, 16Gb@2130, windows 7&10 64bit, Dolby Atmos 5.1.4 Marantz 6010 AVR
I have "only" 8GB RAM...
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
There definitely looks to be a Decompiler problem with the shader you posted above. It's fine up to the last 20 lines or so, then it runs off the rails. I'm looking into that now.
Edit: Actually not sure, but it looks like there is one small tweak in the original that would be worth trying. It's a swapped variable, instead of .xyzw it's .xywz. Very subtle and easy to miss.
It's the last three of the ld_indexed commands, I've unrolled them here to make it more clear about the swizzle. Try this sequence for those, and see if it doesn't fix the missing arms.
The rest of the code could be correct with the compiler being aggressive and rearranging registers.
Acer H5360 (1280x720@120Hz) - ASUS VG248QE with GSync mod - 3D Vision 1&2 - Driver 372.54
GTX 970 - i5-4670K@4.2GHz - 12GB RAM - Win7x64+evilKB2670838 - 4 Disk X25 RAID
SAGER NP9870-S - GTX 980 - i7-6700K - Win10 Pro 1607
Latest 3Dmigoto Release
Bo3b's School for ShaderHackers
i try that "technique", but always the game dump 358 shaders...i try like 10 times / 10 crashes....and same 358 shaders dumped.
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
I also try whith that shader only in the shaderfixes folder, if other shader may corrupt that one but the same.
I don't know what else to try....
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
Keep up the good work!
OK, thanks for trying that out. I'll see if I can get it to generate closer code by tweaking the source. Take me a day or two.
Acer H5360 (1280x720@120Hz) - ASUS VG248QE with GSync mod - 3D Vision 1&2 - Driver 372.54
GTX 970 - i5-4670K@4.2GHz - 12GB RAM - Win7x64+evilKB2670838 - 4 Disk X25 RAID
SAGER NP9870-S - GTX 980 - i7-6700K - Win10 Pro 1607
Latest 3Dmigoto Release
Bo3b's School for ShaderHackers
It's so amazing to see such highly skilled elites and newcomers, all come together under a common interest, to fix issues which otherwise would be impossible, for the good of everyone :)
Windows 10 64-bit, Intel 7700K @ 5.1GHz, 16GB 3600MHz CL15 DDR4 RAM, 2x GTX 1080 SLI, Asus Maximus IX Hero, Sound Blaster ZxR, PCIe Quad SSD, Oculus Rift CV1, DLP Link PGD-150 glasses, ViewSonic PJD6531w 3D DLP Projector @ 1280x800 120Hz native / 2560x1600 120Hz DSR 3D Gaming.
Really don't know what happens in this game.....i will try to tweak the fixing code.
The shader is working fine, don't waste the time in there....unless the ASM code is wrong, but i doubt it
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
I don't know if is possible that the fix only apply in the VS and only in that shadow PS in the pipeline?
The shadow PS is useless, but maybe fixing the v0 (position) in the PS....bringing the "ProjectionMatrix" from the VS....i will test later.
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com