ok so not a good sign that I can't even figure out posting S3D screenshots, they look fine in SBS before posting and look fine if you download from the attachment link - but double up once in the post.
So I tried the DHR fix and it did not work, but this is because DHR was right and this shader is not responsible for the halo. I had MSAA on, which was cleaning up the halo for all situations except when the spray made it visible. So when I disabled the spray. the Halo was still there I just could not see it. So I turned MSAA off and parked near the white lines so I could clearly see halo, and hunted all VS and PS shaders and found none that turned it white or black. Unless it is one of the shaders that turned the whole screen black or scrambled, I am stumped.
So I decided to post screenshots of the other issues, visible only in 3D. Notice the hills and grass in the distance:
[img]https://forums.geforce.com/cmd/default/download-comment-attachment/75049/[/img]
I experimented with graphical settings to see if those areas were linked to anything, and they were tied to shadows. When I turn shadows off it looks like this:
[img]https://forums.geforce.com/cmd/default/download-comment-attachment/75050/[/img]
Is it some kind of OA or something? definitely not playing with it off, but just curious if that helps determine what is causing these areas.
The other issue is reflections or something that looks off, mostly in the distance seen at night:
[img]https://forums.geforce.com/cmd/default/download-comment-attachment/75051/[/img]
As you get closer, it gets easier on the eyes:
[img]https://forums.geforce.com/cmd/default/download-comment-attachment/75052/[/img]
I tried researching some of these issues, but have to say it might be over my head. seems very dependent on engine too, and this Madness engine has issues even in 2D...
ok so not a good sign that I can't even figure out posting S3D screenshots, they look fine in SBS before posting and look fine if you download from the attachment link - but double up once in the post.
So I tried the DHR fix and it did not work, but this is because DHR was right and this shader is not responsible for the halo. I had MSAA on, which was cleaning up the halo for all situations except when the spray made it visible. So when I disabled the spray. the Halo was still there I just could not see it. So I turned MSAA off and parked near the white lines so I could clearly see halo, and hunted all VS and PS shaders and found none that turned it white or black. Unless it is one of the shaders that turned the whole screen black or scrambled, I am stumped.
So I decided to post screenshots of the other issues, visible only in 3D. Notice the hills and grass in the distance:
I experimented with graphical settings to see if those areas were linked to anything, and they were tied to shadows. When I turn shadows off it looks like this:
Is it some kind of OA or something? definitely not playing with it off, but just curious if that helps determine what is causing these areas.
The other issue is reflections or something that looks off, mostly in the distance seen at night:
As you get closer, it gets easier on the eyes:
I tried researching some of these issues, but have to say it might be over my head. seems very dependent on engine too, and this Madness engine has issues even in 2D...
@Shift-E
In those last screenshots, seems 1 or 2 shaders for shadow/light are not grabbed by the Regex. The first one is the shadows of the clouds and the one at night may also be an Halo effect.
Those screenshots looks like that because is playing using SBS Mode (custom shader in 3Dmigoto)...so when you ALT+F1 there are double.
@Shift-E
In those last screenshots, seems 1 or 2 shaders for shadow/light are not grabbed by the Regex. The first one is the shadows of the clouds and the one at night may also be an Halo effect.
Those screenshots looks like that because is playing using SBS Mode (custom shader in 3Dmigoto)...so when you ALT+F1 there are double.
@DHR: I dumped all 957 shaders for the game using 3DMigoto and ran a search for o0.xyzw = r0.xyzw in any of the files, it found 8 PS and 1 VS. Here is the VS shader:
// ---- Created with 3Dmigoto v1.3.10 on Sat May 12 17:44:07 2018
not sure if this would be the one responsible for the Halo, some of the PS look more suspicious than this one. From your post, you mention it could be any rX - meaning X could be any number, not just 0? so any string matching the pattern oX.xyzw = rX.xyzw where X is a number 0-9? are there any other clues in the shader code I could look for that would help identify it as being the source of the Halo?
That shader should be fixed on the fly with the [ShaderRegex_Halos1] Regex.
And also fix the ones with the "o0.xyzw = r1.xyzw" ; "o0.xyzw = r2.xyzw".....and up.
The fix in this post don't work?
[url]https://forums.geforce.com/default/topic/1026902/3d-vision/project-cars-2-3d-fix/post/5338313/#5338313[/url]
You can try also changing r2.w to r2.z in the fixing code.
That shader should be fixed on the fly with the [ShaderRegex_Halos1] Regex.
And also fix the ones with the "o0.xyzw = r1.xyzw" ; "o0.xyzw = r2.xyzw".....and up.
[quote="DHR"]That shader should be fixed on the fly with the [ShaderRegex_Halos1] Regex.
And also fix the ones with the "o0.xyzw = r1.xyzw" ; "o0.xyzw = r2.xyzw".....and up.
The fix in this post don't work?
[url]https://forums.geforce.com/default/topic/1026902/3d-vision/project-cars-2-3d-fix/post/5338313/#5338313[/url]
You can try also changing r2.w to r2.z in the fixing code.
[/quote]
That fix did not work, but that's because I had the wrong shader. I had been focused on the water spray, as that's the only time I saw the halo and disabling the spray seemingly disabled the halo -- but the halo was always there, MSAA was just cleaning it up so I could not see it. I noticed the halo appearing in the rear view mirrors too (which does not have AA), so I turned off all AA and hunted the halo but could not find a shader that affects it.
I see now what you mean about the regex should find those ones anyway, I assumed fixed on the fly shaders would still end up in the shaderfixes folder but that is not the case. So if there is no way to identify the Halo shader without hunting it, then I will have to give up. I went through all VS and PS slowly more than once and never saw a change in the halo (tried both hot pink and skip). I assume the shadow and reflection issues need an even more advanced knowledge to fix too, so I will enjoy the WIP fix as is. Its still awesome, and I can never go back to racing in 2D thats for sure - so thanks for sharing it!!!
and if anyone is really bored and wants to take a crack at the Halo/remaining issues, and fix a game they have no interest in lol...I will leave the link to the Steam Demo of this game:
[url]https://store.steampowered.com/app/378860/Project_CARS_2/[/url]
I assume the fix works the same on the Demo, although I could not confirm since it will not allow me to download if I already own the game. make sure AA is off, and drive over to the white lines on the side of the road and you should easily see the halo issue. Also visible in rainy weather/wet tracks and rear view mirrors.
DHR said:That shader should be fixed on the fly with the [ShaderRegex_Halos1] Regex.
And also fix the ones with the "o0.xyzw = r1.xyzw" ; "o0.xyzw = r2.xyzw".....and up.
That fix did not work, but that's because I had the wrong shader. I had been focused on the water spray, as that's the only time I saw the halo and disabling the spray seemingly disabled the halo -- but the halo was always there, MSAA was just cleaning it up so I could not see it. I noticed the halo appearing in the rear view mirrors too (which does not have AA), so I turned off all AA and hunted the halo but could not find a shader that affects it.
I see now what you mean about the regex should find those ones anyway, I assumed fixed on the fly shaders would still end up in the shaderfixes folder but that is not the case. So if there is no way to identify the Halo shader without hunting it, then I will have to give up. I went through all VS and PS slowly more than once and never saw a change in the halo (tried both hot pink and skip). I assume the shadow and reflection issues need an even more advanced knowledge to fix too, so I will enjoy the WIP fix as is. Its still awesome, and I can never go back to racing in 2D thats for sure - so thanks for sharing it!!!
and if anyone is really bored and wants to take a crack at the Halo/remaining issues, and fix a game they have no interest in lol...I will leave the link to the Steam Demo of this game:
I assume the fix works the same on the Demo, although I could not confirm since it will not allow me to download if I already own the game. make sure AA is off, and drive over to the white lines on the side of the road and you should easily see the halo issue. Also visible in rainy weather/wet tracks and rear view mirrors.
It's really cool to have tried and spend time, I'm unable to do that, it's a shame. Thank you !!!
I will also enjoy the WIP ;-) until an experienced user finds the solution so that we all benefit from pcars2
It's really cool to have tried and spend time, I'm unable to do that, it's a shame. Thank you !!!
I will also enjoy the WIP ;-) until an experienced user finds the solution so that we all benefit from pcars2
yeah, I do not think its being actively worked on by anyone. I would definitely donate again to anyone that could improve on DHR's WIP fix, but I think we just have to enjoy the fix as is..
yeah, I do not think its being actively worked on by anyone. I would definitely donate again to anyone that could improve on DHR's WIP fix, but I think we just have to enjoy the fix as is..
Sorry...i'm not planning to look this game soon. But looking the logs you can see how the Regex applied the fixes and replicate with other broken shaders....probably there are some shaders that the Regex don't catch.
Sorry...i'm not planning to look this game soon. But looking the logs you can see how the Regex applied the fixes and replicate with other broken shaders....probably there are some shaders that the Regex don't catch.
ok, thank you for the news
Sometimes with the DHR's WIP fix, I have a huge problem of convergence, the two images are too far apart, even changing with the CTRL + 6 key, I see double, I am forced to restart pcars2. It's very random.
The fix is almost good, but it persists visual discomfort, a pity that I do not have the knowledge and time to devote myself to it and try to improve. The vision3D with pcars2 adds a lot of feeling and immersion.
Sometimes with the DHR's WIP fix, I have a huge problem of convergence, the two images are too far apart, even changing with the CTRL + 6 key, I see double, I am forced to restart pcars2. It's very random.
The fix is almost good, but it persists visual discomfort, a pity that I do not have the knowledge and time to devote myself to it and try to improve. The vision3D with pcars2 adds a lot of feeling and immersion.
So I tried the DHR fix and it did not work, but this is because DHR was right and this shader is not responsible for the halo. I had MSAA on, which was cleaning up the halo for all situations except when the spray made it visible. So when I disabled the spray. the Halo was still there I just could not see it. So I turned MSAA off and parked near the white lines so I could clearly see halo, and hunted all VS and PS shaders and found none that turned it white or black. Unless it is one of the shaders that turned the whole screen black or scrambled, I am stumped.
So I decided to post screenshots of the other issues, visible only in 3D. Notice the hills and grass in the distance:
I experimented with graphical settings to see if those areas were linked to anything, and they were tied to shadows. When I turn shadows off it looks like this:
Is it some kind of OA or something? definitely not playing with it off, but just curious if that helps determine what is causing these areas.
The other issue is reflections or something that looks off, mostly in the distance seen at night:
As you get closer, it gets easier on the eyes:
I tried researching some of these issues, but have to say it might be over my head. seems very dependent on engine too, and this Madness engine has issues even in 2D...
In those last screenshots, seems 1 or 2 shaders for shadow/light are not grabbed by the Regex. The first one is the shadows of the clouds and the one at night may also be an Halo effect.
Those screenshots looks like that because is playing using SBS Mode (custom shader in 3Dmigoto)...so when you ALT+F1 there are double.
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
not sure if this would be the one responsible for the Halo, some of the PS look more suspicious than this one. From your post, you mention it could be any rX - meaning X could be any number, not just 0? so any string matching the pattern oX.xyzw = rX.xyzw where X is a number 0-9? are there any other clues in the shader code I could look for that would help identify it as being the source of the Halo?
And also fix the ones with the "o0.xyzw = r1.xyzw" ; "o0.xyzw = r2.xyzw".....and up.
The fix in this post don't work?
https://forums.geforce.com/default/topic/1026902/3d-vision/project-cars-2-3d-fix/post/5338313/#5338313
You can try also changing r2.w to r2.z in the fixing code.
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
That fix did not work, but that's because I had the wrong shader. I had been focused on the water spray, as that's the only time I saw the halo and disabling the spray seemingly disabled the halo -- but the halo was always there, MSAA was just cleaning it up so I could not see it. I noticed the halo appearing in the rear view mirrors too (which does not have AA), so I turned off all AA and hunted the halo but could not find a shader that affects it.
I see now what you mean about the regex should find those ones anyway, I assumed fixed on the fly shaders would still end up in the shaderfixes folder but that is not the case. So if there is no way to identify the Halo shader without hunting it, then I will have to give up. I went through all VS and PS slowly more than once and never saw a change in the halo (tried both hot pink and skip). I assume the shadow and reflection issues need an even more advanced knowledge to fix too, so I will enjoy the WIP fix as is. Its still awesome, and I can never go back to racing in 2D thats for sure - so thanks for sharing it!!!
and if anyone is really bored and wants to take a crack at the Halo/remaining issues, and fix a game they have no interest in lol...I will leave the link to the Steam Demo of this game:
https://store.steampowered.com/app/378860/Project_CARS_2/
I assume the fix works the same on the Demo, although I could not confirm since it will not allow me to download if I already own the game. make sure AA is off, and drive over to the white lines on the side of the road and you should easily see the halo issue. Also visible in rainy weather/wet tracks and rear view mirrors.
I will also enjoy the WIP ;-) until an experienced user finds the solution so that we all benefit from pcars2
MY WEB
Helix Mod - Making 3D Better
My 3D Screenshot Gallery
Like my fixes? you can donate to Paypal: dhr.donation@gmail.com
Sometimes with the DHR's WIP fix, I have a huge problem of convergence, the two images are too far apart, even changing with the CTRL + 6 key, I see double, I am forced to restart pcars2. It's very random.
The fix is almost good, but it persists visual discomfort, a pity that I do not have the knowledge and time to devote myself to it and try to improve. The vision3D with pcars2 adds a lot of feeling and immersion.